CZ Testing v2.1.4

General Category => Comments => Topic started by: Dave on Mar 11, 2023, 06:13 AM

Title: Ambassador
Post by: Dave on Mar 11, 2023, 06:13 AM
As I'm not pursuing the News theme I thought I'd help out with this.

Border on menu buttons on hover goes white, in the original theme they are gold.

To fix change
border: 1px solid #fff; to
border: 1px solid #ffde74; as below

/* Level 1 hover effects. */
.dropmenu li a:hover, .dropmenu li:hover a, .dropmenu li a:focus, #top_info > li > a:hover, #top_info > li:hover > a, #top_info > li > a.open {
    background: linear-gradient(to bottom, #4c4c4c 10%, #1b1b1b 90%);
    border: 1px solid #ffde74;
    color: #fff;
    cursor: pointer;
    text-decoration: none;
    box-shadow: 0 4px 4px rgba(255, 255, 255, 0.1) inset;
    text-shadow: 1px 1px 3px rgba(255, 255, 255, 0.5);
}

Images for this

Original theme

hoveroriginal.png

New 2.1.3 theme

hover2.1.3.png

In the original the drop menu on hover does not have a border, but I'm guessing you've done that deliberately. I think it looks better the way you've got it
=============================

The checkbox alignment is not right in this theme either for chrome. If you hover over the checkbox the border radius disappears. The fix is to remove line 1507

border-radius: 1px;
checkbox1.png

checkbox2.png 




[attachment deleted by admin]
Title: Re: Ambassador
Post by: Dave on Mar 11, 2023, 06:36 AM
The navigate section horizontal alignment is also out

You'll see that 'CZ Testing 2.1.3' does not line up with the text following it

before

navigationb4.png

after

navigationafter.png

to fix remove line  1366 'line-height: 1.1em;'

.navigate_section ul li {
float: left;
padding-bottom: 3px;
/*line-height: 1.1em;*/
color: #989898;
/* text-shadow: 1px 1px 0 #fff; */
}

The fix is OK on both Chrome and Firefox

[attachment deleted by admin]
Title: Re: Ambassador
Post by: Bocool on Mar 11, 2023, 12:26 PM
Since you've brought up the browser issues with Cleanwhite I was considering going back to Ambassador to see if it had the same issues. Thanks!

Btw, the one here is for v2.1.2 and does need to be updated to 2.1.3.
Title: Re: Ambassador
Post by: Bocool on Mar 11, 2023, 08:07 PM
How does it look now?

EDIT: Not sure if you've noticed but I've started adding numbers to the names of the themes like Ambassador to tell the various versions of a certain smf version of the theme...like Ambassador212a. This may change in the future to all numbers instead of letters, tho.
Title: Re: Ambassador
Post by: Dave on Mar 12, 2023, 03:46 AM
It's looking good now Steve. I'll have a good check around later and see if there is anything else.
Title: Re: Ambassador
Post by: Bocool on Mar 12, 2023, 03:39 PM
I had a look at Ambassador and noticed that the White border were still there...at least in Firefox. Then I realized that the wrong code was edited. It was this and the 'border-top' and 'border-left' needed to be removed:

/* Levels 2 and 3 submenu wrapper. */
.dropmenu li ul, .top_menu {
    z-index: 90;
    position: absolute;
    display: none;
    min-width: 18.2em;
    padding: 0.5em;
    font-weight: normal;
    border: 1px solid #bd9851;
    border-left: solid 1px #bbb;
    border-top: solid 1px #ccc;
    border-radius: 4px;
    box-shadow: 3px 3px 4px rgba(0, 0, 0, 0.3);
    background: #1b1b1b;
}
Title: Re: Ambassador
Post by: Dave on Mar 12, 2023, 06:22 PM
Ok I'll check it out tomorrow. My PC is switched off now and I can't hover with the tablet.

I'm pretty sure that it's working ok on my test site though, maybe I only checked it in Brave
Title: Re: Ambassador
Post by: Bocool on Mar 12, 2023, 06:57 PM
I just saw this about 15 mins ago and prolly just missed you. I was cooking dinner for tomorrow, it's my turn. LOL

Yeah, I'm sure that was the issue because nothing in this theme should have anything like that in it. I've noticed a few other issues like the color of the textarea when you type a post. It's black and something is blocking it from me turning it white. I can see the white briefly but then it tuns black. I can change it in dev and it works but not in the real code. :o

I'll have another look later or tomorrow.
Title: Re: Ambassador
Post by: Dave on Mar 13, 2023, 03:44 AM
Oh I get what you mean now, sorry I thought you meant the quickbuttton borders but you meant the dropbox borders. For me I like the white border on hover, so I'll leave mine as it is.

As far as the textarea is concerned, if I understand you correctly then what you mean is it turns black on hover and then changes when you insert the cursor into it, if so the fix is below

line 54
remove

textarea:hover {
background: #000;
}

or change to a colour you like :)
Title: Re: Ambassador
Post by: Dave on Mar 13, 2023, 10:24 AM
UPDATE: Ok what's odd here is that I did the browser inspect and after clicking on the index.ccs line, I /* out the line I've said above.

Now the thing is that this should not have changed the index.css file permanently itself and upon refreshing the page would go back to how it was, but it hasn't.

I have gone into the FTP and looked at the css file and it's last update was yesterday, I'm guessing that was by you, now for some reason when I hover over the reply box it doesn't change anymore. I have cleared the cache in both Firefox and Brave, I've removed the cookies from this site but it still doesn't change on hover over.

Does it still, do it for you?


It still does it on my test site, but I haven't changed the css file yet
Title: Re: Ambassador
Post by: Bocool on Mar 13, 2023, 08:27 PM
Ok, I'm starting to hear the 'Twilight Zone's" theme song. LMAO

I logged in and read what you posted and started typing to respond and now the text is white?!?!?! WTF???

I think there may be some caching issues with the last browser upgrades? No, I haven't changed anything. May you have to close the browser then open it again for some things to work right? One thing that did catch my eye last yesterday while I was editing the sceditor file is the last date in the copyright is 2013??   Seriously???

And SMF still uses this? Also, I just noticed that (at least on this site with the default smileys) if you try to use 3 question marks in a row you'll have problems trying to type something after it cause one of the text for the smileys has always been the same...3 question marks. Try typing a question followed by 3 question marks then type a space then start typing again. LOL
Title: Re: Ambassador
Post by: Dave on Mar 14, 2023, 03:47 AM
Quote from: Bocool on Mar 13, 2023, 08:27 PMI think there may be some caching issues with the last browser upgrades? No, I haven't changed anything. May you have to close the browser then open it again for some things to work right?

I cleared the cache and cleared all the cookies from both Firefox and Brave, the only thing I didn't to was to uninstall them both, so heaven knows why it's not doing it now. I even cleared the site cache too, maybe that's why it was OK for you after I did that
Title: Re: Ambassador
Post by: Bocool on Mar 14, 2023, 08:20 PM
Yeah, possibly so...
Title: Re: Ambassador
Post by: Bocool on Mar 16, 2023, 10:05 PM
It's late but I've got a few changes coming for this. ;)
Title: Re: Ambassador
Post by: Dave on Mar 17, 2023, 03:38 AM
OK I await with bated breath  ;D
Title: Re: Ambassador
Post by: Bocool on Mar 17, 2023, 06:42 PM
I meant to show you part of it yesterday but forgot. LOL

take a look at the bottom of the Stats Center. You'll see the arrows have changed color. ;) I did the one yesterday and may do the other tonight.

EDIT: If you click on "Receive Emails And Alerts" and hover over any of the options the 'a' text becomes white and is unreadable. I solved it by making the color black about line 4217:

.notify_dropdown a:hover, .notify_dropdown a:focus {
border-color: #ddd;
background: #fff; /* fallback for some browsers */
background-image: linear-gradient(#e2e9f3 0%, #fff 70%);
color: #000;
}
Title: Re: Ambassador
Post by: Bocool on Mar 18, 2023, 09:58 AM
I'm also going to do the page arrows.
Title: Re: Ambassador
Post by: Bocool on Mar 18, 2023, 04:35 PM
I've created a new Ambassador v2.1.3a. I've also changed this footer to add the version number and am going to add the same to the new theme.

EDIT:

1.  Template files changed.
2.  Images copied.
3.  Calendar.css done.
4.  Admin.css done.
Title: Re: Ambassador
Post by: Dave on Mar 18, 2023, 06:21 PM
Well this isn't confusing.

Look at the screenshot, it's default curve, using the black background from Ambassador in this reply text box with Cleanwhite in the footer lol

[attachment deleted by admin]
Title: Re: Ambassador
Post by: Bocool on Mar 18, 2023, 07:31 PM
Yes, I m not done with the coding yet. LOL I didn't do anything to the index.css yet but am working on the other files because they are the easiest. That has do with the jquery.sceditor.default.css file which is already done. ;)

I just noticed this cause i'm working on the files and also jamming to some music and in and out of the kitchen. LOL

5.  jquery files done. Forgot to post this earlier. LOL
Title: Re: Ambassador
Post by: Bocool on Mar 18, 2023, 07:41 PM
I see there are a few images that are blue that can be changed to gold-ish. LOL

6.  Index.css is partially done. I had to change the text so we can see it until it is finished. LOL
7.  slider.min.css done.
Title: Re: Ambassador
Post by: Bocool on Mar 19, 2023, 10:11 AM
Should be looking good but haven't checked the mobile view yet. About to get a snack and take a short nap...
Title: Re: Ambassador
Post by: Bocool on Mar 19, 2023, 03:55 PM
8.  I've changed most of the blue icons to gold. :)

https://www.jpr62.com/theme/index.php?topic=2425.msg15284
Title: Re: Ambassador
Post by: Dave on Mar 20, 2023, 03:28 AM
Sorry, life happened again so I wasn't around much yesterday
Title: Re: Ambassador
Post by: Dave on Mar 20, 2023, 04:05 AM
Quote from: Dave on Mar 20, 2023, 03:28 AMSorry, life happened again so I wasn't around much yesterday
Title: Re: Ambassador
Post by: Bocool on Mar 20, 2023, 06:23 PM
No problem. RL comes first. ;)
Title: Re: Ambassador
Post by: Dave on Mar 21, 2023, 09:45 AM
So where are we at with his now Steve?
Title: Re: Ambassador
Post by: Bocool on Mar 21, 2023, 07:52 PM
It's mostly done although I've just noticed an issue. I think it's because of Firefox's caching and it makes me think something is wrong when it isn't? It only does it maybe once per week or so. I'll need to look into this...
Title: Re: Ambassador
Post by: Dave on Mar 22, 2023, 03:28 AM
I have just noticed that the quickbuttons in the post that they are no lowercase and not Caps as they were before. I that deliberate?
Title: Re: Ambassador
Post by: Bocool on Mar 22, 2023, 06:40 PM
Hmmm, not sure what happened. LOL Yesterday I thought they looked different somehow but was busy doing other things and forgot about it.
Title: Re: Ambassador
Post by: Bocool on Mar 23, 2023, 06:34 PM
I must've remove the code by mistake.

The only thing I haven't checked yet is the mobile version but everything else looks good, so far.
Title: Re: Ambassador
Post by: Bocool on Mar 24, 2023, 07:14 PM
Mobile menu needs a bit of fixing...

EDIT:

1.  I've changed the hamburger color to gold.
2.  Updated responsive.css menu to look like the last version.
Title: Re: Ambassador
Post by: Dave on Mar 25, 2023, 12:51 PM
Quote from: Bocool on Mar 24, 2023, 07:14 PM1.  I've changed the hamburger color to gold.

What is the hamburger colour?
Title: Re: Ambassador
Post by: Bocool on Mar 25, 2023, 05:15 PM
#967439 I had to use this as it's a .svg image:

https://boxy-svg.com/
Title: Re: Ambassador
Post by: Bocool on Mar 25, 2023, 10:26 PM
I've decided to change the dropdowns on the main menu to look exactly like the original. But, I'm having a problem with it. It isn't looking the same and I can't seem to get the 'a" or "a span" to change...

Otherwise, all else looks good. :)
Title: Re: Ambassador
Post by: Dave on Mar 28, 2023, 05:25 PM
I looked for a few hours today and got nowhere, so I posted in the Charter members area of SMF to see if anyone has the answer. Kindred replied but the code he suggested is not in the Ambassador css.

I tried adding the code but that didn't work either.

So I don't know how to fix it, I search and stopped all the linear-gradient code from running but nothing seems to change it
Title: Re: Ambassador
Post by: Dave on Mar 28, 2023, 05:30 PM
Update, this is what was posted on SMF

Quote
Quote from: TwitchisMental on Mar 28, 2023, 03:52 PM
Quote from: Dave J on Mar 28, 2023, 01:41 PM
Quote from: Kindred on Mar 28, 2023, 11:36 AMdo you mean this?
Code (index.css:3950) Select
.dropmenu li ul, .top_menu, .dropmenu li li:hover, .button, .dropmenu li li:hover > a, .dropmenu li li a:focus, .dropmenu li li a:hover, #top_section, .quickbuttons > li, .quickbuttons li ul, .quickbuttons li ul li a:hover, .quickbuttons ul li a:focus, .inline_mod_check, .popup_window, #inner_section, .post_options ul, .post_options ul a:hover, .post_options ul a:focus, .notify_dropdown a:hover, .notify_dropdown a:focus {
  background: #fff;
    background-image: none;
  background-image: linear-gradient(#e2e9f3 0%, #fff 70%);
[/code[


Thanks Kindred I will look into that. An initial look at the index.css that's code is not showing. I'm wondering if the fact it's missing is causing the issue.
If what Kindred has suggested does not work it will be this right here -

.dropmenu li:hover li a, .dropmenu li li a {
    background: #1b1b1b;
    padding: 0 9px;
    color: #ddd;
    border: none;
    line-height: 2.2em;
    text-shadow: none;
}

 
Title: Re: Ambassador
Post by: Bocool on Mar 28, 2023, 07:33 PM
Hmmm, I've had a look and see what I've possibly done wrong. I'm not a fan of the way SMF has grouped the classes. They say it will make sites run faster. However, it a headache to code because if you want to change something that is groups with others you change them and which makes it harder to keep up with what has changed. ;)

So, when I start on a theme I break some of it up, especially code like that for the dropmenus and topmenu as they are mostly grouped together. I like to split them up and then groups like ones together making it easier to make changes to the code, if needed. When I'm done I'll regroup things that are the same only if they have the same code. What happened is I can see duplicates which may be causing conflicts. SMF does the same but I guess I didn't check for it as I was coding. :o

I'll have go over the dropmenus and make sure everything is right and there are no conflicts.
Title: Re: Ambassador
Post by: Dave on Mar 29, 2023, 05:29 AM
It's OK I've found it

Index.css

line 805 - 814 replace what's current there with

/* Level 1 hover effects. */
.dropmenu li a:hover, .dropmenu li:hover a, .dropmenu li a:focus, #top_info > li > a:hover, #top_info > li:hover > a, #top_info > li > a.open {
    /*background: linear-gradient(to bottom, #4c4c4c 10%, #1b1b1b 90%);*/
    border: 1px solid #ffde74;
    color: #fff;
    cursor: pointer;
    text-decoration: none;
    /*box-shadow: 0 4px 4px rgba(255, 255, 255, 0.1) inset;*/
    text-shadow: 1px 1px 3px rgba(255, 255, 255, 0.5);
}

Once that's done the buttons are flat as per the original...and it's all my own work ;)


UPDATE: What I have noticed is with the original when you hover over the menu button the colour of the background to the drop menu is a lighter colour than when you hover over the actual drop menu buttons.

My wife wants me to fix a mobile table for her, which includes making new drawers to replace the missing ones, so my time on here is going to be limited for a while, but please keep me up to date with any issues and as always if I can help I will.
Title: Re: Ambassador
Post by: Bocool on Mar 29, 2023, 09:19 PM
Quote from: Dave on Mar 29, 2023, 05:29 AMIt's OK I've found it

Index.css

line 805 - 814 replace what's current there with

/* Level 1 hover effects. */
.dropmenu li a:hover, .dropmenu li:hover a, .dropmenu li a:focus, #top_info > li > a:hover, #top_info > li:hover > a, #top_info > li > a.open {
    /*background: linear-gradient(to bottom, #4c4c4c 10%, #1b1b1b 90%);*/
    border: 1px solid #ffde74;
    color: #fff;
    cursor: pointer;
    text-decoration: none;
    /*box-shadow: 0 4px 4px rgba(255, 255, 255, 0.1) inset;*/
    text-shadow: 1px 1px 3px rgba(255, 255, 255, 0.5);
}

Once that's done the buttons are flat as per the original...and it's all my own work ;)
Thanks, you've saved me a bit of time tonight. LOL

Quote from: Dave on Mar 29, 2023, 05:29 AMUPDATE: What I have noticed is with the original when you hover over the menu button the colour of the background to the drop menu is a lighter colour than when you hover over the actual drop menu buttons.
Yes, that's what I'm trying to do. However, something is still not quite right but I'll figure it out sooner or later. LOL
Title: Re: Ambassador
Post by: Bocool on Mar 29, 2023, 10:34 PM
OK, I've got the hover color right but there's still a light border at the top of the fist dropmenu item and to the right of all of them....hmmmm...

EDIT: OK, I've given up for tonight. Maybe tomorrow. LOL
Title: Re: Ambassador
Post by: Dave on Mar 30, 2023, 03:57 AM
OK I've now solved that too.

The problem for the, what looked like a border. was just a width issue, so reducing the width got rid of that and the top part was padding, so the padding has been reduced from 7px to 6px.

So onwards and upwards...as they say

index.css

from line 950 - 960

replace

.dropmenu li ul {
    z-index: 90;
    display: none;
    position: absolute;
    width: 19.2em;
    font-weight: normal;
    border: none;
/*    border-bottom: 1px solid #212121; */
    background: url(../images/theme/menu_gfx.png) 0 -100px no-repeat;
    padding: 7px 0 0 0;
}

with

.dropmenu li ul {
z-index: 90;
display: none;
position: absolute;
width: 19em;
font-weight: normal;
border: none;
/* border-bottom: 1px solid #212121; */
background: url(../images/theme/menu_gfx.png) 0 -100px no-repeat;
/padding: 6px 0 0 0;
}
Title: Re: Ambassador
Post by: Bocool on Mar 30, 2023, 07:34 PM
Ha! About the time I was ready to eat and go to bed I had started wondering if it was a width/padding/margin issue. However, you should also change the width to:

width: 19em;
Well, at least in FF it removes what looks like a border on the right.

One thing I did notice last night was that there's actually curves on the highlighted bits. I noticed it yesterday cause I was changing the background to white just to see if there was something else causing the 'borders'.
Title: Re: Ambassador
Post by: Bocool on Mar 30, 2023, 07:52 PM
About line 890, make sure 'background' and 'border' are set to none. ;)

/* Necessary to allow highlighting of 1st level while hovering over submenu. */
.dropmenu li:hover li a, .dropmenu li:hover li a span, .dropmenu li:hover li a, .dropmenu li:hover li {
background: none;
/* padding: 0 9px; */
color: #ddd;
border: none;
line-height: 2.2em;
text-shadow: none;
border-radius: none;
}
Title: Re: Ambassador
Post by: Dave on Mar 31, 2023, 02:29 AM
I'm not sure why but I'm not getting your replies emails anymore.

I've sent a test email and I get that fine but not your replies. I have clicked all the buttons again so lets see what happen tonight  ;)
Title: Re: Ambassador
Post by: Bocool on Mar 31, 2023, 11:57 PM
I think I've seen other complain about this on other sites and servers since 2.1 started...
Title: Re: Ambassador
Post by: Dave on Apr 01, 2023, 02:44 AM
I didn't get any notification of your reply

Quote from: Bocool on Mar 31, 2023, 11:57 PMI think I've seen other complain about this on other sites and servers since 2.1 started...

Yes it happened on Quizland too, I tried various different email addresses, including the ones that come with the host too but that didn't make any difference.

Now I've opted to pay for SMTP emails, it was $100 for a year from SMTP2Go so now everyone is getting the emails. Maybe by the time the SMTP contract expires the SMF php will work again.
Title: Re: Ambassador
Post by: Bocool on Apr 01, 2023, 06:22 PM
Well, I hear the next SMF version isn't too far off...

Sorry, I wasn't around today. There's been thunderstorms most of the day and those make me sleepy. LOL
Title: Re: Ambassador
Post by: Dave on Apr 02, 2023, 02:32 AM
Quote from: Bocool on Apr 01, 2023, 06:22 PMSorry, I wasn't around today. There's been thunderstorms most of the day and those make me sleepy. LOL

As we have both said 'life happens' so don't beat yourself up over it.

Still no email btw. It is odd as I was getting them up to and including 29th March
Title: Re: Ambassador
Post by: TwitchisMental on Apr 02, 2023, 09:54 PM
Quote from: Bocool on Mar 28, 2023, 07:33 PMHmmm, I've had a look and see what I've possibly done wrong. I'm not a fan of the way SMF has grouped the classes. They say it will make sites run faster. However, it a headache to code because if you want to change something that is groups with others you change them and which makes it harder to keep up with what has changed. ;)

So, when I start on a theme I break some of it up, especially code like that for the dropmenus and topmenu as they are mostly grouped together. I like to split them up and then groups like ones together making it easier to make changes to the code, if needed. When I'm done I'll regroup things that are the same only if they have the same code. What happened is I can see duplicates which may be causing conflicts. SMF does the same but I guess I didn't check for it as I was coding. :o

I'll have go over the dropmenus and make sure everything is right and there are no conflicts.

There are pros and cons of it.  I have also found myself having to split the dropmenu and top_menu classes due to styling reasons XD.

-----------
Title: Re: Ambassador
Post by: Bocool on Apr 02, 2023, 10:03 PM
Yes, if you do it right it works. When 2.1.1 beta when to 2.1.1.x beta I started making my own 'default themes and it helped a lot! The problem is when there are new upgrades. Then you have to go over the code again.
Title: Re: Ambassador
Post by: TwitchisMental on Apr 02, 2023, 10:07 PM
Quote from: Bocool on Apr 02, 2023, 10:03 PMYes, if you do it right it works. When 2.1.1 beta when to 2.1.1.x beta I started making my own 'default themes and it helped a lot! The problem is when there are new upgrades. Then you have to go over the code again.

Yeah that is the unfortunate side of making things for betas/rcs. I had to do it for all of my themes when RC4 went to 2.1 stable. 

Thankfully now with 2.1 being stable very few theme changes will be made in future releases. Any that are made, are not really required for the theme to work with newer versions.
Title: Re: Ambassador
Post by: Bocool on Apr 02, 2023, 10:10 PM
Don't say that or you'll jinx us! LMAO
Title: Re: Ambassador
Post by: TwitchisMental on Apr 02, 2023, 10:25 PM
Alright let's get to a few quick things.

One quick note, if you do not want a property to exist anymore, just remove it. No need to comment it out.

A few things to fix

Find

.inner {
    padding: 7px 8px 2px 2px;
    margin: 0;
    border-top: 1px solid #333;
    box-shadow: 0 1px 0 #fff inset;
    min-height: 85px;
    word-wrap: break-word; /* IE fallback */
    overflow-wrap: break-word;
    color: #ddd;
}

Change to

.inner {
    padding: 7px 8px 2px 2px;
    margin: 0;
    border-top: 1px solid #333;
    box-shadow: 0 1px 0 #333 inset;
    min-height: 85px;
    word-wrap: break-word; /* IE fallback */
    overflow-wrap: break-word;
    color: #ddd;
}

This will change the color of the white line under date of the post.

-----------------

Next is the new post indicator

Find -

/* The "new" button */
.new_posts, a.new_posts {
    display: inline-block;
    position: relative;
    top: -2px;
    padding: 0 4px;
    background: linear-gradient(#f97b00,#884d00);
    color: #fff;
    font: 9px/15px verdana, sans-serif;
    border-radius: 2px;
    opacity: 0.8;
}

Replace With

/* The "new" button */
.new_posts, a.new_posts {
    display: inline-block;
    position: relative;
    top: -2px;
    padding: 0 4px;
    background: linear-gradient(to bottom, rgb(255, 222, 116) 10%, rgb(92, 51, 30) 90%);
    color: #000;
    font: 9px/15px verdana, sans-serif;
    border-radius: 2px;
    opacity: 0.8;
}

This will make the new post indicator have black text and have a similar background to the cat_bar background.

----------

I would change this -

.windowbg:hover hr {
  background: rgb(255, 255, 255);
}

to

.windowbg:hover hr {
  background: rgb(255, 222, 116);
}

Just to match the theme a bit more. This changes the hr line color from white to the cat_bar yellowish color. I think it looks a bit better that way, but this just my opinion.

Then we got the admin.css that needs a few border colors updated.

For example -

.action_admin .table_grid td {
    border: 1px solid #ddd;
}

I'd change the border to the same color used in alot of other areas.

border: 1px solid rgb(189, 152, 81);


Edit : I use the rgb color format personally, but it is easy enough to look up the hexcode XD.

Edit 2: Speaking from experience... Dark themes are a pain in the butt when it comes to all the white borders and such lol.
Title: Re: Ambassador
Post by: Bocool on Apr 02, 2023, 10:30 PM
Thank you for the fixes!

I comment things out when I'm changing code. I comment it so I don't forget what the original code was. When the theme is ready for release I delete them all before releasing it. ;)

EDIT: This is especially true if I forget to backup the file before editing it. LOL
Title: Re: Ambassador
Post by: TwitchisMental on Apr 02, 2023, 10:34 PM
Quote from: Bocool on Apr 02, 2023, 10:30 PMThank you for the fixes!

I comment things out when I'm changing code. I comment it so I don't forget what the original code was. When the theme is ready for release I delete them all before releasing it. ;)

EDIT: This is especially true if I forget to backup the file before editing it. LOL

You're welcome :).
Title: Re: Ambassador
Post by: Bocool on Apr 02, 2023, 10:44 PM
OK, almost 11PM here and time to take a shower and eat before going to bed to get up for work in the morning.

Btw, if you need FTP access let me know. ;)
Title: Re: Ambassador
Post by: TwitchisMental on Apr 02, 2023, 10:52 PM
Quote from: Bocool on Apr 02, 2023, 10:44 PMOK, almost 11PM here and time to take a shower and eat before going to bed to get up for work in the morning.

Btw, if you need FTP access let me know. ;)
Alright, you have a great night.

I don't NEED it, unless you want me to make edits directly.

Otherwise I can just keep posting things that I notice here. I just want to help in any way that I can without causing any issues :) .
Title: Re: Ambassador
Post by: Bocool on Apr 02, 2023, 11:02 PM
You have a great night too.

I doubt you'll cause more issue than I do! ;D
Title: Re: Ambassador
Post by: Dave on Apr 03, 2023, 02:31 AM
Thanks for all the help Twitch, it's much appreciated
Title: Re: Ambassador
Post by: Dave on Apr 03, 2023, 02:45 AM
Quote from: TwitchisMental on Apr 02, 2023, 11:57 PMAlright I got some sticky,sticky&locked,locked, and unapproved topics made.

The background colors for all of these need to be updated :) .

Sticky & Locked background could be like the original

background: rgb(48, 48, 48);
The unapproved section I think should be -

background: rgb(148, 48, 48)

Sorry guys I deleted the wrong post but I did quote you Twitch before I deleted it so the original post is in here.

I was wondering where this code was from then it occurred to me that it might have been after you changed the code.
Title: Re: Ambassador
Post by: Dave on Apr 03, 2023, 03:43 AM
I found something that I'm not sure why I didn't see it before.

The quick_mod_jump drop box is not right either.

Index.css

Line 179

/* Give disabled input elements a different style */
input[disabled], textarea[disabled], select[disabled], .button.disabled, .button[disabled]:hover {
    background: #eee;
    color: #999;
    border-color: #b6b6b6;
    opacity: 0.8;
    cursor: default;
}

Replace with

/* Give disabled input elements a different style */
input[disabled], textarea[disabled], select[disabled], .button.disabled, .button[disabled]:hover {
    background: rgb(48, 48, 48);
    color: ##bd9851;
    border-color: #a28875;
    opacity: 0.8;
    cursor: default;
}

The only thing I can't find relating to that, is when you hover over the options of where to move something they are blue; should they be another colour, if so what and where do we change it?

[attachment deleted by admin]
Title: Re: Ambassador
Post by: Dave on Apr 03, 2023, 04:12 AM
OK now I'm really confused, I know you're thinking that's not difficult for you Dave but, things seem to have gone backwards.

The inline_mod_check button has now gone back to it's original setting. We changed that weeks ago and it was fine on both here and my test site. The only thing I can think of that would have changed it that dramatically is when you went from 2.1.2 to 2.1.3 Steve.

I will update this post again when I've scrolled back to see how we fixed it.

It seems it might have been when we were working on Cleanwhite.

I'm working on how to fix it here

UPDATE: I've done a comparison between the index.css here and the one on my test site. Apart from a couple of differences, some of which are Twitch's fixes, there are pretty much the same.

I have attached my one to this post so you can compare and test it out if you wish. I should add that it also fixes the '.inline_mod_check' button issue on here.


[attachment deleted by admin]
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 10:35 AM
Quote from: Dave on Apr 03, 2023, 02:45 AM
Quote from: TwitchisMental on Apr 02, 2023, 11:57 PMAlright I got some sticky,sticky&locked,locked, and unapproved topics made.

The background colors for all of these need to be updated :) .

Sticky & Locked background could be like the original

background: rgb(48, 48, 48);
The unapproved section I think should be -

background: rgb(148, 48, 48)

Sorry guys I deleted the wrong post but I did quote you Twitch before I deleted it so the original post is in here.

I was wondering where this code was from then it occurred to me that it might have been after you changed the code.

These are found in the index.css, I have made no changes to anything. Around Line 3094 is where it starts.

I am simply pointing out issues and where/how to resolve :).
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 10:36 AM
Quote from: Dave on Apr 03, 2023, 03:43 AMI found something that I'm not sure why I didn't see it before.

The quick_mod_jump drop box is not right either.

Index.css

Line 179

/* Give disabled input elements a different style */
input[disabled], textarea[disabled], select[disabled], .button.disabled, .button[disabled]:hover {
    background: #eee;
    color: #999;
    border-color: #b6b6b6;
    opacity: 0.8;
    cursor: default;
}

Replace with

/* Give disabled input elements a different style */
input[disabled], textarea[disabled], select[disabled], .button.disabled, .button[disabled]:hover {
    background: rgb(48, 48, 48);
    color: ##bd9851;
    border-color: #a28875;
    opacity: 0.8;
    cursor: default;
}

The only thing I can't find relating to that, is when you hover over the options of where to move something they are blue; should they be another colour, if so what and where do we change it?

You have an extra # on the color property.

Quote from: Dave on Apr 03, 2023, 04:12 AMOK now I'm really confused, I know you're thinking that's not difficult for you Dave but, things seem to have gone backwards.

The inline_mod_check button has now gone back to it's original setting. We changed that weeks ago and it was fine on both here and my test site. The only thing I can think of that would have changed it that dramatically is when you went from 2.1.2 to 2.1.3 Steve.

I will update this post again when I've scrolled back to see how we fixed it.

It seems it might have been when we were working on Cleanwhite.

I'm working on how to fix it here

UPDATE: I've done a comparison between the index.css here and the one on my test site. Apart from a couple of differences, some of which are Twitch's fixes, there are pretty much the same.

I have attached my one to this post so you can compare and test it out if you wish. I should add that it also fixes the '.inline_mod_check' button issue on here.



You have alot of validation issues, see the attached file.

W3C-CSS-Validator-results-for-TextArea-CSS-level-3-SVG-.png

[attachment deleted by admin]
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 10:51 AM
I have attached the index.css with all errors resolved. (Still shows validation issues due to the scrollbar stuff, but that is fine its just pseudo stuff that isn't completely supported yet.)


Another note, browser prefixes are not really needed anymore, they were common back in the 2.0 days due to css3 still being standardized. There are some exceptions though like the scrollbar stuff XD.

Edit: Went ahead and included the sticky/locked topic stuff.

[attachment deleted by admin]
Title: Re: Ambassador
Post by: Dave on Apr 03, 2023, 10:58 AM
Quote from: TwitchisMental on Apr 03, 2023, 10:51 AMI have attached the index.css with all errors resolved. (Still shows validation issues due to the scrollbar stuff, but that is fine its just pseudo stuff that isn't completely supported yet.)


Another note, browser prefixes are not really needed anymore, they were common back in the 2.0 days due to css3 still being standardized. There are some exceptions though like the scrollbar stuff XD.

Edit: Went ahead and included the sticky/locked topic stuff.



Thanks Twitch it's much appreciated
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 10:59 AM
Quote from: Dave on Apr 03, 2023, 10:58 AM
Quote from: TwitchisMental on Apr 03, 2023, 10:51 AMI have attached the index.css with all errors resolved. (Still shows validation issues due to the scrollbar stuff, but that is fine its just pseudo stuff that isn't completely supported yet.)


Another note, browser prefixes are not really needed anymore, they were common back in the 2.0 days due to css3 still being standardized.



Thanks Twitch it's much appreciated

No problem, attached a newer index.css above with some other fixes included. XD
Title: Re: Ambassador
Post by: Dave on Apr 03, 2023, 11:09 AM
Quote from: TwitchisMental on Apr 03, 2023, 10:59 AM
Quote from: Dave on Apr 03, 2023, 10:58 AM
Quote from: TwitchisMental on Apr 03, 2023, 10:51 AMI have attached the index.css with all errors resolved. (Still shows validation issues due to the scrollbar stuff, but that is fine its just pseudo stuff that isn't completely supported yet.)


Another note, browser prefixes are not really needed anymore, they were common back in the 2.0 days due to css3 still being standardized.



Thanks Twitch it's much appreciated

No problem, attached a newer index.css above with some other fixes included. XD

You're a good man Twitch...I don't care what the others say   ;D
Title: Re: Ambassador
Post by: Dave on Apr 03, 2023, 11:14 AM
Line 179 the input not resolved in your new index.css Twitch


/* Give disabled input elements a different style */
input[disabled], textarea[disabled], select[disabled], .button.disabled, .button[disabled]:hover {
background: #eee;
color: #999;
border-color: #b6b6b6;
opacity: 0.8;
cursor: default;
}

No resolved in your new index.css Twitch


Resolve is

/* Give disabled input elements a different style */
input[disabled], textarea[disabled], select[disabled], .button.disabled, .button[disabled]:hover {
background: rgb(48, 48, 48);
color: #999;
border-color: #a28875;
opacity: 0.8;
cursor: default;
}
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 11:19 AM
Quote from: Dave on Apr 03, 2023, 11:14 AMLine 179 the input not resolved in your new index.css Twitch


/* Give disabled input elements a different style */
input[disabled], textarea[disabled], select[disabled], .button.disabled, .button[disabled]:hover {
    background: #eee;
    color: #999;
    border-color: #b6b6b6;
    opacity: 0.8;
    cursor: default;
}

No resolved in your new index.css Twitch


Resolve is

/* Give disabled input elements a different style */
input[disabled], textarea[disabled], select[disabled], .button.disabled, .button[disabled]:hover {
    background: rgb(48, 48, 48);
    color: #999;
    border-color: #a28875;
    opacity: 0.8;
    cursor: default;
}

Yeah didn't mess with this to be honest, just the other stuff I mentioned.

Have included it in the attached file below. Also adjusted the hover border color for input boxes to match the original 2.0 theme. Also updated the a.newpost indicator background color.

[attachment deleted by admin]
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 07:33 PM
Thanks a lot guys!!!

And sorry cause I guess I was so tired last night I used the code for Cleanwhite for Ambassador! LOL I wanted to go to bed but was very happy to get some help. :)
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 07:42 PM
/* Colors for background of posts requiring approval */
.approvebg {
color: #222;
background: #ffeaea;
}
.approvebg2 {
color: #222;
background: #fff2f2;
}

These will need to be updated aswell. I would use the same background as the .windowbg.approvetopic background. Which is #943030 .

Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 07:45 PM
Done and added a Recycle Topics board. ;)

EDIT: And, uploaded you index.css. Thanks! 8)
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 08:03 PM
So noticed an issue with the title_Bar/bg.

You have a background-image on every instance of titlebg or title_bar.

You only need it to show on the .title_bar class.
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 08:05 PM
So, you are saying remove the background from .titlebg?
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 08:07 PM
Quote from: Bocool on Apr 03, 2023, 08:05 PMSo, you are saying remove the background from .titlebg?

Yes you seem to have a background on every instance of it.

All of these -

h4.titlebg, .titlebg, h4.subbg, .subbg {
    background: #202020 url(../images/theme/main_block.png) no-repeat 0 -120px;
    color: #555;
    font-family: "Tahoma", sans-serif;
    font-weight: bold;
    overflow: hidden;
    padding: 6px 12px 5px 12px;
    text-shadow: none;
}
.titlebg {
    background: #202020 url(../images/theme/main_block.png) no-repeat 0 -120px;
    color: #555;
    font-family: "Tahoma", sans-serif;
    font-weight: bold;
    overflow: hidden;
    padding: 6px 12px 5px 12px;
    text-shadow: none;
    border: none;
}
h3.titlebg {
    background: linear-gradient(to bottom, #ffde74 10%, #5c331e 90%);
    color: #000;
    font-family: "Tahoma", sans-serif;
    font-weight: bold;
    overflow: hidden;
    padding: 6px 12px 5px 12px;
    text-shadow: none;
    border-top-left-radius: 4px;
    border-top-right-radius: 4px;
}
h4.titlebg {
    background: linear-gradient(to bottom, #ffde74 10%, #5c331e 90%);
    color: #000;
    font-family: "Tahoma", sans-serif;
    font-weight: bold;
    overflow: hidden;
    padding: 6px 12px 5px 12px;
    text-shadow: none;
    border-top-left-radius: 4px;
    border-top-right-radius: 4px;
}

No need for the background on them.

It should be under .title_bar like so

.title_bar {
/*    border: 1px solid #ddd;
    border-top: 2px solid #ff9400;
    border-bottom: 2px solid #bf6900; */
    background: linear-gradient(to bottom, #ffde74 10%, #5c331e 90%);
    color: #666;
    border-radius: 2px 2px 0 0;
    margin: 5px 0 0 0;
}

Wouldn't hurt to add this aswell for the links -

.title_bar a {
    color: #000;
    text-decoration: none;
}
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 08:10 PM
Okey, dokey... I'll remove them.

Btw, I've changed the moderation link color to black. Only the exclamation point. It should stay like that until you approve it, correct?

a.moderation_link, a.moderation_link:visited {
  font-weight: bold;
  padding: 0px 6px;
  background: #BD9851;
  color: #000;
}
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 08:13 PM
Quote from: Bocool on Apr 03, 2023, 08:10 PMOkey, dokey... I'll remove them.

Btw, I've changed the moderation link color to black. Only the exclamation point. It should stay like that until you approve it, correct?

a.moderation_link, a.moderation_link:visited {
  font-weight: bold;
  padding: 0px 6px;
  background: #BD9851;
  color: #000;
}


That works.  Yes it will show the icon until the topic and/or post has been approved.
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 08:18 PM
Alright this should resolve the title_bar stuffs .

Find -

/* TitleBar & SubBar */
.title_bar {
/* border: 1px solid #ddd;
border-top: 2px solid #ff9400;
border-bottom: 2px solid #bf6900; */
background: #1b1b1b;
color: #666;
border-radius: 2px 2px 0 0;
margin: 5px 0 0 0;
}
.sub_bar {
border-bottom: 1px solid #000;
text-shadow: none;
background: none;
clear: both;
}
h3.subbg,h4.subbg, .subbg {
background: #202020 url(../images/theme/main_block.png) no-repeat 0 -120px;
color: #ddd;
font-family: "Tahoma", sans-serif;
font-weight: bold;
overflow: hidden;
padding: 6px 12px 5px 12px;
text-shadow: none;
}
h3.titlebg, h4.titlebg, .titlebg {
background: #202020 url(../images/theme/main_block.png) no-repeat 0 -120px;
color: #555;
font-family: "Tahoma", sans-serif;
font-weight: bold;
overflow: hidden;
padding: 6px 12px 5px 12px;
text-shadow: none;
}
.titlebg {
background: #202020 url(../images/theme/main_block.png) no-repeat 0 -120px;
color: #555;
font-family: "Tahoma", sans-serif;
font-weight: bold;
overflow: hidden;
padding: 6px 12px 5px 12px;
text-shadow: none;
border: none;
}

.subbg a {
background: none;
color: #808080;
text-decoration: none;
}
.titlebg a {
background: none;
color: #000;
text-decoration: none;
}
.title_bar + .windowbg, .title_bar + .roundframe {
margin-top: -1px;
border-top-left-radius: 0;
border-top-right-radius: 0;
}

Replace With

/* TitleBar & SubBar */
.title_bar {
    border: none;
background: linear-gradient(to bottom, #ffde74 10%, #5c331e 90%);
color: #666;
border-radius: 2px 2px 0 0;
margin: 5px 0 0 0;
}
.sub_bar {
border-bottom: 1px solid #000;
text-shadow: none;
background: none;
clear: both;
}
h3.subbg, h4.subbg, .subbg {
background: #202020 url(../images/theme/main_block.png) no-repeat 0 -120px;
color: #ddd;
font-family: "Tahoma", sans-serif;
font-weight: bold;
overflow: hidden;
padding: 6px 12px 5px 12px;
text-shadow: none;
}
h3.titlebg, h4.titlebg, .titlebg {
color: #000;
font-family: "Tahoma", sans-serif;
font-weight: bold;
overflow: hidden;
padding: 6px 12px 5px 12px;
text-shadow: none;
}

.subbg a {
background: none;
color: #808080;
text-decoration: none;
}
.titlebg a {
background: none;
color: #000;
text-decoration: none;
}
.title_bar + .windowbg, .title_bar + .roundframe {
margin-top: -1px;
border-top-left-radius: 0;
border-top-right-radius: 0;
}
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 08:19 PM
I've been debating whether I should add a little spacing below the wrapper...
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 08:23 PM
Quote from: Bocool on Apr 03, 2023, 08:19 PMI've been debating whether I should add a little spacing below the wrapper...
You could if you wanted to follow the original.
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 08:28 PM
Adding a color to this make the text black and hard to read. Removing it turns it to gold:

.titlebg a {
    color: #000;
    text-decoration: none;
}
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 08:30 PM
Quote from: TwitchisMental on Apr 03, 2023, 08:23 PM
Quote from: Bocool on Apr 03, 2023, 08:19 PMI've been debating whether I should add a little spacing below the wrapper...
You could if you wanted to follow the original.

Well, for the most part, yes, I want it to look like the original. However, I've been looking for ways to 'modernize' the themes a bit but without losing the original look.
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 08:32 PM
Quote from: Bocool on Apr 03, 2023, 08:28 PMAdding a color to this make the text black and hard to read. Removing it turns it to gold:

.titlebg a {
    color: #000;
    text-decoration: none;
}


Yes because the background is not gold like it should be.

Try doing the following -

Find -

/* TitleBar & SubBar */
.title_bar {
/*    border: 1px solid #ddd;
    border-top: 2px solid #ff9400;
    border-bottom: 2px solid #bf6900; */
    background: #1b1b1b;
    color: #666;
    border-radius: 2px 2px 0 0;
    margin: 5px 0 0 0;
}
.sub_bar {
    border-bottom: 1px solid #000;
    text-shadow: none;
    background: none;
/*    box-shadow: 0 -1px 0 #999 inset; */
    clear: both;
}
h3.subbg, .subbg {
    background: #202020 url(../images/theme/main_block.png) no-repeat 0 -120px;
    color: #ddd;
    font-family: "Tahoma", sans-serif;
    font-weight: bold;
    overflow: hidden;
    padding: 6px 12px 5px 12px;
    text-shadow: none;
}
h4.titlebg, .titlebg, h4.subbg, .subbg {
    background: #202020 url(../images/theme/main_block.png) no-repeat 0 -120px;
    color: #555;
    font-family: "Tahoma", sans-serif;
    font-weight: bold;
    overflow: hidden;
    padding: 6px 12px 5px 12px;
    text-shadow: none;
}
.titlebg {
    background: #202020 url(../images/theme/main_block.png) no-repeat 0 -120px;
    color: #555;
    font-family: "Tahoma", sans-serif;
    font-weight: bold;
    overflow: hidden;
    padding: 6px 12px 5px 12px;
    text-shadow: none;
    border: none;
}
h3.titlebg {
    background: linear-gradient(to bottom, #ffde74 10%, #5c331e 90%);
    color: #000;
    font-family: "Tahoma", sans-serif;
    font-weight: bold;
    overflow: hidden;
    padding: 6px 12px 5px 12px;
    text-shadow: none;
    border-top-left-radius: 4px;
    border-top-right-radius: 4px;
}
h4.titlebg {
    background: linear-gradient(to bottom, #ffde74 10%, #5c331e 90%);
    color: #000;
    font-family: "Tahoma", sans-serif;
    font-weight: bold;
    overflow: hidden;
    padding: 6px 12px 5px 12px;
    text-shadow: none;
    border-top-left-radius: 4px;
    border-top-right-radius: 4px;
}
.subbg a {
    background: none;
    color: #808080;
    text-decoration: none;
}
.titlebg a {
    background: none;
    color: #000;
    text-decoration: none;
}
.title_bar + .windowbg, .title_bar + .roundframe {
    margin-top: -1px;
    border-top-left-radius: 0;
    border-top-right-radius: 0;
}

Replace With -

/* TitleBar & SubBar */
.title_bar {
    border: none;
    background: linear-gradient(to bottom, #ffde74 10%, #5c331e 90%);
    color: #666;
    border-radius: 2px 2px 0 0;
    margin: 5px 0 0 0;
}
.sub_bar {
    border-bottom: 1px solid #000;
    text-shadow: none;
    background: none;
    clear: both;
}
h3.subbg, h4.subbg, .subbg {
    background: #202020 url(../images/theme/main_block.png) no-repeat 0 -120px;
    color: #ddd;
    font-family: "Tahoma", sans-serif;
    font-weight: bold;
    overflow: hidden;
    padding: 6px 12px 5px 12px;
    text-shadow: none;
}
h3.titlebg, h4.titlebg, .titlebg {
    color: #000;
    font-family: "Tahoma", sans-serif;
    font-weight: bold;
    overflow: hidden;
    padding: 6px 12px 5px 12px;
    text-shadow: none;
}

.subbg a {
    background: none;
    color: #808080;
    text-decoration: none;
}
.titlebg a {
    background: none;
    color: #000;
    text-decoration: none;
}
.title_bar + .windowbg, .title_bar + .roundframe {
    margin-top: -1px;
    border-top-left-radius: 0;
    border-top-right-radius: 0;
}

Quote from: Bocool on Apr 03, 2023, 08:30 PM
Quote from: TwitchisMental on Apr 03, 2023, 08:23 PM
Quote from: Bocool on Apr 03, 2023, 08:19 PMI've been debating whether I should add a little spacing below the wrapper...
You could if you wanted to follow the original.

Well, for the most part, yes, I want it to look like the original. However, I've been looking for ways to 'modernize' the themes a bit but without losing the original look.


Fair enough, wasn't sure how close to the original you want it. I think the footer looks fine as is for the most part.

I think there is a better way to place it and could minimize how many lines there are though.
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 08:39 PM
I'm open...what's the better way?

Btw, I've changed the border-radius to match the the rest of the bars on the home page.

.title_bar {
  border: none;
 background: linear-gradient(to bottom, #ffde74 10%, #5c331e 90%);
 color: #666;
 border-radius: 6px 6px 0 0;
 margin: 5px 0 0 0;
}
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 08:44 PM
Quote from: Bocool on Apr 03, 2023, 08:39 PMI'm open...what's the better way?

Btw, I've changed the border-radius to match the the rest of the bars on the home page.

.title_bar {
  border: none;
 background: linear-gradient(to bottom, #ffde74 10%, #5c331e 90%);
 color: #666;
 border-radius: 6px 6px 0 0;
 margin: 5px 0 0 0;
}


Oh and add this aswell -

.title_bar a {
    color: #000;
    text-decoration: none;   
}

That will make the links in message.index for the title bar visible .

As far as the footer, I would just place it within the wrapper. You can do this in index.template.php .

Similar to my Bend,RadicalRed, or TealSplash Themes.

Then you can get rid of the margin/height trick you are currently using. From there you could then add a margin-bottom to the wrapper to create that space like the original.


Edit: I can make a demo of it on my local server to demo if you would like.
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 08:54 PM
The footer is already in the wrapper.

function template_body_below()
{
global $context, $txt, $scripturl, $modSettings;

echo '
</div><!-- #main_content_section -->
</div><!-- #content_section -->
</div><!-- #wrapper -->
</div><!-- #footerfix -->';

// Show the footer with copyright, terms and help links.
echo '
<div id="footer">
<div class="inner_wrap">';

// There is now a global "Go to top" link at the right.
echo '
<ul class="centertext">
<li><a href="', $scripturl, '?action=help">', $txt['help'], '</a> ', (!empty($modSettings['requireAgreement'])) ? '| <a href="' . $scripturl . '?action=agreement">' . $txt['terms_and_rules'] . '</a>' : '', ' | <a href="#top_section">', $txt['go_up'], ' &#9650;</a></li>
<li>Original Ambassador by <a href="https://www.jpr62.com/theme/" target="_blank" class="new_win" title="Crip Zone">Crip</a></li>
<li>Updated to v2.1.3a by <a href="https://www.jpr62.com/theme/" target="_blank" class="new_win" title="The Crip Zone Team">The Crip Zone Team</a></li>
<li>', theme_copyright(), '</li>
</ul>';

// Show the load time?
if ($context['show_load_time'])
echo '
<p class="centertext">', sprintf($txt['page_created_full'], $context['load_time'], $context['load_queries']), '</p>';

echo '
</div>
</div><!-- #footer -->';

}
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 08:58 PM
Um, the bottom should have:

echo '
</div><!-- #footer -->
</div><!-- #wrapper -->';
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 09:21 PM
It is not currently within the wrapper.

I have attached the index.template.php which will place it properly.

Then its a matter of adjusting the css :).



[attachment deleted by admin]
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 09:26 PM
The CSS stuff -

Find -

#main_content_section {
text-align: left;
padding: 10px 12px 120px 12px;
border: 1px solid #000000;
background: #1b1b1b;
}
#main_content_section:hover {
text-align: left;
padding: 10px 12px 120px 12px;
border: 1px solid #000000;
}
#main_content_section::after {
content: "";
display: block;
clear: both;
}
/* Footer is now full-width by default. */
/* The footer with copyright links etc. */
#footer {
margin: -130px 0 0 0;
padding: 2px 0 5px;
background: rgba(255, 255, 255, 0);
border-bottom-left-radius: 8px;
flex: none;
height: 130px;
border-bottom-right-radius: 8px;
color: #bd9851;
width: auto;
text-align: center;
}

Replace -

#main_content_section {
text-align: left;
padding: 10px 12px 10px 12px;
border: 1px solid #000000;
border-bottom: none;
background: #1b1b1b;
}
#main_content_section::after {
content: "";
display: block;
clear: both;
}
/* Footer is now full-width by default. */
/* The footer with copyright links etc. */
#footer {
margin: 0px;
padding: 0px;
background: #1b1b1b;
color: #bd9851;
width: auto;
text-align: center;
border: 1px solid #000;
border-top: none;
}
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 09:30 PM
Ok, I was wrong. :o

I'll add it...
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 09:36 PM
Ah! Wasn't within #footerfix! I've thought something didn't look right but it worked so I gave up on it. LOL
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 09:41 PM
Quote from: Bocool on Apr 03, 2023, 09:36 PMAh! Wasn't within #footerfix! I've thought something didn't look right but it worked so I gave up on it. LOL
Haha now just adjust the css with the above css and you are good to go on that.
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 09:52 PM
Ok, something is not right. LOL
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 09:53 PM
Quote from: Bocool on Apr 03, 2023, 09:52 PMOk, something is not right. LOL
Why do you say that? It looks all good to me.
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 09:57 PM
A lot more space at the top than the bottom.

EDIT: On some pages more than others...
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 09:59 PM
Quote from: Bocool on Apr 03, 2023, 09:57 PMA lot more space at the top than the bottom.

Ah I gotcha, you can adjust the padding as needed. Something like 10px on the bottom would be about right.

Note it will vary depending on margins and padding of other sections aswell. #main_content_section being the main one, which you could just remove the padding from the bottom of.

A few ways of going about it haha.

EDIT :

There also seems to be a <br> below the quick reply which is causing the extra space.
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 10:16 PM
Honestly, the sequence of the HTML in the php files like index.template.php has always confused me. I'm 'Old School'. Things go in a certain order when coding but that not the same with SMF. Personally, I find myBB MUCH easier to code. And can very easily migrate SMF themes to myBB without much problems at all.

I can upgrade the SMF themes to myBB without much of a problem at all. I've done it. And may eventually do it again, if not to get people interested.
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 10:20 PM
Quote from: Bocool on Apr 03, 2023, 10:16 PMHonestly, the sequence of the HTML in the php files like index.template.php has always confused me. I'm 'Old School'. Things go in a certain order when coding but that not the same with SMF. Personally, I find myBB MUCH easier to code. And can very easily migrate SMF themes to myBB without much problems at all.

I can upgrade the SMF themes to myBB without much of a problem at all. I've done it. And may eventually do it again, if not to get people interested.

I can agree, MyBB's theme and template system is much easier to work with. I remember converting my first MyBB theme (Blooming Red) to SMF.. that was a learning curve and a half XD.

Sadly MyBB is behind the times nowadays. (Not even responsive by default)

Xenforo is also a-lot easier in my opinion.


Hopefully I can help you get more use to the SMF template system :). So if you got questions do not be afraid to ask :).

Edit : Using Notepad++ instead of the built in editor is a start :D .
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 10:27 PM
I haven't played with Xenforo in quite a few years. I've been testing software since the mid-late 80's. Windows, a lot of the old games (which I still have on floppies or on my Pc), forums, blogs, CMS's, etc. That what I do when I used to get bored and still do...on occasion! LOL

Now, Since I 've got into themes I've stuck with that...and security issues.
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 10:31 PM
Quote from: Bocool on Apr 03, 2023, 10:27 PMI haven't played with Xenforo in quite a few years. I've been testing software since the mid-late 80's. Windows, a lot of the old games (which I still have on floppies or on my Pc), forums, blogs, CMS's, etc. That what I do when I used to get bored and still do...on occasion! LOL

Now, Since I 've got into themes I've stuck with that...and security issues.
I can relate XD.

You ever play with other operating systems like Linux,BSD, and/or Solaris ?
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 10:36 PM
Yup! I've played with a lot of them. I used to be a tester for Steam when they started making it for linux. ;)

I have a ton of Steam games from years ago. Half-life, Counter Strike, etc. I also have a ton of old shareware games on my PC like Doom, Rise of the Triad, the original Wolfenstein, etc. and they still work and play them once in a blue moon. LOL

I used to run gaming servers, etc. ;)
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 10:40 PM
That's how I got into PC's. I thought they were for games back in the mid 80's. I've found the 'internet' and could download them for free. Getting them to work right required a bit of learning how to code...dBase, DOS, Machine Language, etc. But I got away from that.

I've even made a few of my own games back then. LOL I made a Super Mario type game where the crack addict would jump for crack pips and crack and kill the drug dealers! LMFAO People used to tell me that I was not right in the head. LMAO
Title: Re: Ambassador
Post by: TwitchisMental on Apr 03, 2023, 10:42 PM
Quote from: Bocool on Apr 03, 2023, 10:40 PMThat's how I got into PC's. I thought they were for games back in the mid 80's. I've found the 'internet' and could download them for free. Getting them to work right required a bit of learning how to code...dBase, DOS, Machine Language, etc. But I got away from that.

I've even made a few of my own games back then. LOL I made a Super Mario type game where the crack addict would jump for crack pips and crack and kill the drug dealers! LMFAO People used to tell me that I was not right in the head. LMAO
Haha that is awesome.

My biggest addiction gaming wise was Starcraft/Starcraft Broodwar.  I made UMS maps and mods for it for the longest time. Heck it was the map making community that introduced me to Linux haha.
Title: Re: Ambassador
Post by: Bocool on Apr 03, 2023, 11:06 PM
I might still have the original Starcraft game somewhere. I have a ton of games in my attic on floppies and CD's. Haven't been up there in awhile.

My fav gaming is still the old Dungeons and Dragons/RPG type of games. Going on quests, etc.

OK, almost past bedtime. Gotta eat and get some rest. LOL

Title: Re: Ambassador
Post by: Dave on Apr 04, 2023, 02:45 AM
Morning men,

Looks like you guys have been busy.

As a footnote, for some reason it seems that Virgin Broadband in the UK is having issues with US and CA connections, my default broadmand is Virgin, but I also have another connection and I can connect, I suppose that is obvious as I'm posting :)

Steve, can you check your host to see if my 86.10.21.40 IP has been banned please? I know on SMFH there was something about Virgin connections.

OK off to golf, so see you later, although it is 02.44 where you guys are...or there abouts any way.
Title: Re: Ambassador
Post by: TwitchisMental on Apr 04, 2023, 02:47 PM
#footer {
    margin: 0px;
    padding: 10px 0px;
    background: #1b1b1b;
    color: #bd9851;
    width: auto;
    text-align: center;
    border: 1px solid #000;
    border-top: none;
}

#main_content_section {
    text-align: left;
    padding: 10px 12px 0px 12px;
    border: 1px solid #000000;
    border-bottom: none;
    background: #1b1b1b;
}

Making these two changes makes the footer look better. The post area will still push it down a bit due to the <br> . Not a big deal to me though.

Also noticed that the logo for Ambass is missing on this site .
Title: Re: Ambassador
Post by: Bocool on Apr 04, 2023, 08:42 PM
@Dave No, you haven't pissed me off enough for me to ban you...yet. ;D

@TwitchisMental Yup! Looks better! ;)

For the logo, I tend to just add it in the theme settings, although I should add it in the index.template file. It would look better me thinks.

Title: Re: Ambassador
Post by: TwitchisMental on Apr 04, 2023, 09:13 PM
Quote from: Bocool on Apr 04, 2023, 08:42 PM@Dave No, you haven't pissed me off enough for me to ban you...yet. ;D

@TwitchisMental Yup! Looks better! ;)

For the logo, I tend to just add it in the theme settings, although I should add it in the index.template file. It would look better me thinks.



I like having it display the logo by default myself and then the user can change it to whatever they like via the theme settings.

In the footer I think we should combine the Original Ambassador by Crip & Updated to v2.1.3a by The Crip Zone Team text to the same line.
Title: Re: Ambassador
Post by: Bocool on Apr 04, 2023, 09:46 PM
OK, we can do that for the logo.

Actually, the footer used to be like that then I changed it during the beta versions because of the length it didn't look right in mobile version. But I haven't revisited it yet...
Title: Re: Ambassador
Post by: TwitchisMental on Apr 04, 2023, 10:01 PM
Quote from: Bocool on Apr 04, 2023, 09:46 PMOK, we can do that for the logo.

Actually, the footer used to be like that then I changed it during the beta versions because of the length it didn't look right in mobile version. But I haven't revisited it yet...

Looks good until you get below 480px. Maybe we can shorten the wording a bit to make it fit.

Something like - Ambassador by Crip. - Updated for SMF 2.1 By TheCripZone

That looks good until 360px width. Most phones do not go below that resolution width anyways.

Attached an image just for demo -

Screen Shot 2023-04-04 at 21.01.34.png


[attachment deleted by admin]
Title: Re: Ambassador
Post by: Bocool on Apr 04, 2023, 10:20 PM
Sound good to me. :)

Just to be clear, it should be like this?

echo '
<ul class="centertext">
<li><a href="', $scripturl, '?action=help">', $txt['help'], '</a> ', (!empty($modSettings['requireAgreement'])) ? '| <a href="' . $scripturl . '?action=agreement">' . $txt['terms_and_rules'] . '</a>' : '', ' | <a href="#top_section">', $txt['go_up'], ' &#9650;</a></li>
<li>Ambassador by <a href="https://www.jpr62.com/theme/" target="_blank" class="new_win" title="Crip Zone">Crip</a></li>
<li>Updated for SMF 2.1 By TheCripZone <a href="https://www.jpr62.com/theme/" target="_blank" class="new_win" title="The Crip Zone Team"></a></li>
<li>', theme_copyright(), '</li>
</ul>';
Title: Re: Ambassador
Post by: TwitchisMental on Apr 04, 2023, 10:26 PM
Close, but not quite.

    echo '
        <ul class="centertext">
            <li><a href="', $scripturl, '?action=help">', $txt['help'], '</a> ', (!empty($modSettings['requireAgreement'])) ? '| <a href="' . $scripturl . '?action=agreement">' . $txt['terms_and_rules'] . '</a>' : '', ' | <a href="#top_section">', $txt['go_up'], ' &#9650;</a></li>
            <li>Ambassador by <a href="https://www.jpr62.com/theme/" target="_blank" class="new_win" title="Crip Zone">Crip</a> | Updated for SMF 2.1 By <a href="https://www.jpr62.com/theme/" target="_blank" class="new_win" title="The Crip Zone Team">TheCripZone</a></li>
            <li>', theme_copyright(), '</li>
        </ul>';

Title: Re: Ambassador
Post by: Bocool on Apr 04, 2023, 10:37 PM
Done!
Title: Re: Ambassador
Post by: TwitchisMental on Apr 04, 2023, 10:48 PM
Quote from: Bocool on Apr 04, 2023, 10:37 PMDone!
Awesome sauce.
Title: Re: Ambassador
Post by: Bocool on Apr 04, 2023, 10:52 PM
I'm not sure if I like you. You say to many of my sayings like 'cool beans' and 'awesome sauce'. LMAO copycat!
Title: Re: Ambassador
Post by: TwitchisMental on Apr 04, 2023, 10:57 PM
Quote from: Bocool on Apr 04, 2023, 10:52 PMI'm not sure if I like you. You say to many of my sayings like 'cool beans' and 'awesome sauce'. LMAO copycat!

I'll have you know... I have said these things before I was even on the internet :p .

Title: Re: Ambassador
Post by: Bocool on Apr 04, 2023, 10:59 PM
Me too. Been surfing the net for 35+ years. ;)
Title: Re: Ambassador
Post by: Dave on Apr 05, 2023, 02:48 AM
Gents we still have an issue with the 'inline_mod_check' on here.

To fix go to

.quickbuttons > li:last-child > a, .inline_mod_check:last-child {
border-radius: 0 4px 4px 0;
}

replace with

.quickbuttons > li:last-child > a, .inline_mod_check:last-child {
border-radius: 0 4px 4px 0;
border: 1px solid #ffde74;
}

once that's done the height  needs adjusting at

.quickbuttons > li {
float: left;
display: inline;
height: 23.5px;
border-radius: 1px;
box-shadow: 1px 1px 1px rgba(0, 0, 0, 0.1);
padding: 0 1px 0 1px;
color: #222;
overflow: visible;
}

change the height from 23.5px to 24px.

I've checked this on Chrome based and Firefox and it works OK on both
Title: Re: Ambassador
Post by: Bocool on Apr 05, 2023, 07:40 PM
You know, I did notice the border was missing but got side-tracked and forgot about it. LOL

Fixed! :)