News:

This one time at band camp.

Main Menu

Ambassador

Started by Dave, Mar 11, 2023, 06:13 AM

Previous topic - Next topic

0 Members and 2 Guests are viewing this topic.

Bocool

I think I've seen other complain about this on other sites and servers since 2.1 started...

Dave

I didn't get any notification of your reply

Quote from: Bocool on Mar 31, 2023, 11:57 PMI think I've seen other complain about this on other sites and servers since 2.1 started...

Yes it happened on Quizland too, I tried various different email addresses, including the ones that come with the host too but that didn't make any difference.

Now I've opted to pay for SMTP emails, it was $100 for a year from SMTP2Go so now everyone is getting the emails. Maybe by the time the SMTP contract expires the SMF php will work again.

Bocool

Well, I hear the next SMF version isn't too far off...

Sorry, I wasn't around today. There's been thunderstorms most of the day and those make me sleepy. LOL

Dave

Quote from: Bocool on Apr 01, 2023, 06:22 PMSorry, I wasn't around today. There's been thunderstorms most of the day and those make me sleepy. LOL

As we have both said 'life happens' so don't beat yourself up over it.

Still no email btw. It is odd as I was getting them up to and including 29th March

TwitchisMental

Quote from: Bocool on Mar 28, 2023, 07:33 PMHmmm, I've had a look and see what I've possibly done wrong. I'm not a fan of the way SMF has grouped the classes. They say it will make sites run faster. However, it a headache to code because if you want to change something that is groups with others you change them and which makes it harder to keep up with what has changed. ;)

So, when I start on a theme I break some of it up, especially code like that for the dropmenus and topmenu as they are mostly grouped together. I like to split them up and then groups like ones together making it easier to make changes to the code, if needed. When I'm done I'll regroup things that are the same only if they have the same code. What happened is I can see duplicates which may be causing conflicts. SMF does the same but I guess I didn't check for it as I was coding. :o

I'll have go over the dropmenus and make sure everything is right and there are no conflicts.

There are pros and cons of it.  I have also found myself having to split the dropmenu and top_menu classes due to styling reasons XD.

-----------
This is a signature.

Bocool

Yes, if you do it right it works. When 2.1.1 beta when to 2.1.1.x beta I started making my own 'default themes and it helped a lot! The problem is when there are new upgrades. Then you have to go over the code again.

TwitchisMental

Quote from: Bocool on Apr 02, 2023, 10:03 PMYes, if you do it right it works. When 2.1.1 beta when to 2.1.1.x beta I started making my own 'default themes and it helped a lot! The problem is when there are new upgrades. Then you have to go over the code again.

Yeah that is the unfortunate side of making things for betas/rcs. I had to do it for all of my themes when RC4 went to 2.1 stable. 

Thankfully now with 2.1 being stable very few theme changes will be made in future releases. Any that are made, are not really required for the theme to work with newer versions.
This is a signature.

Bocool

Don't say that or you'll jinx us! LMAO

TwitchisMental

#53
Alright let's get to a few quick things.

One quick note, if you do not want a property to exist anymore, just remove it. No need to comment it out.

A few things to fix

Find

.inner {
    padding: 7px 8px 2px 2px;
    margin: 0;
    border-top: 1px solid #333;
    box-shadow: 0 1px 0 #fff inset;
    min-height: 85px;
    word-wrap: break-word; /* IE fallback */
    overflow-wrap: break-word;
    color: #ddd;
}

Change to

.inner {
    padding: 7px 8px 2px 2px;
    margin: 0;
    border-top: 1px solid #333;
    box-shadow: 0 1px 0 #333 inset;
    min-height: 85px;
    word-wrap: break-word; /* IE fallback */
    overflow-wrap: break-word;
    color: #ddd;
}

This will change the color of the white line under date of the post.

-----------------

Next is the new post indicator

Find -

/* The "new" button */
.new_posts, a.new_posts {
    display: inline-block;
    position: relative;
    top: -2px;
    padding: 0 4px;
    background: linear-gradient(#f97b00,#884d00);
    color: #fff;
    font: 9px/15px verdana, sans-serif;
    border-radius: 2px;
    opacity: 0.8;
}

Replace With

/* The "new" button */
.new_posts, a.new_posts {
    display: inline-block;
    position: relative;
    top: -2px;
    padding: 0 4px;
    background: linear-gradient(to bottom, rgb(255, 222, 116) 10%, rgb(92, 51, 30) 90%);
    color: #000;
    font: 9px/15px verdana, sans-serif;
    border-radius: 2px;
    opacity: 0.8;
}

This will make the new post indicator have black text and have a similar background to the cat_bar background.

----------

I would change this -

.windowbg:hover hr {
  background: rgb(255, 255, 255);
}

to

.windowbg:hover hr {
  background: rgb(255, 222, 116);
}

Just to match the theme a bit more. This changes the hr line color from white to the cat_bar yellowish color. I think it looks a bit better that way, but this just my opinion.

Then we got the admin.css that needs a few border colors updated.

For example -

.action_admin .table_grid td {
    border: 1px solid #ddd;
}

I'd change the border to the same color used in alot of other areas.

border: 1px solid rgb(189, 152, 81);


Edit : I use the rgb color format personally, but it is easy enough to look up the hexcode XD.

Edit 2: Speaking from experience... Dark themes are a pain in the butt when it comes to all the white borders and such lol.
This is a signature.

Bocool

#54
Thank you for the fixes!

I comment things out when I'm changing code. I comment it so I don't forget what the original code was. When the theme is ready for release I delete them all before releasing it. ;)

EDIT: This is especially true if I forget to backup the file before editing it. LOL

TwitchisMental

Quote from: Bocool on Apr 02, 2023, 10:30 PMThank you for the fixes!

I comment things out when I'm changing code. I comment it so I don't forget what the original code was. When the theme is ready for release I delete them all before releasing it. ;)

EDIT: This is especially true if I forget to backup the file before editing it. LOL

You're welcome :).
This is a signature.

Bocool

OK, almost 11PM here and time to take a shower and eat before going to bed to get up for work in the morning.

Btw, if you need FTP access let me know. ;)

TwitchisMental

Quote from: Bocool on Apr 02, 2023, 10:44 PMOK, almost 11PM here and time to take a shower and eat before going to bed to get up for work in the morning.

Btw, if you need FTP access let me know. ;)
Alright, you have a great night.

I don't NEED it, unless you want me to make edits directly.

Otherwise I can just keep posting things that I notice here. I just want to help in any way that I can without causing any issues :) .
This is a signature.

Bocool

You have a great night too.

I doubt you'll cause more issue than I do! ;D

Dave

Thanks for all the help Twitch, it's much appreciated